Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into fixing _SHL and _SHR #158

Open
mkilgore opened this issue Sep 4, 2022 · 0 comments
Open

Look into fixing _SHL and _SHR #158

mkilgore opened this issue Sep 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mkilgore
Copy link
Contributor

mkilgore commented Sep 4, 2022

See some of the notes in #153. Basically, _SHL and _SHR only have one implementation in libqb.cpp, which takes a uint64_t. This causes some unexpected results due to type casting to uint64_t, but it's also not clear we can just fix it to work like _ROR and _ROL without it being a breaking change.

IMO a first good step would be to add some tests like the rotations tests for _SHL and _SHR that show the current behavior. It would explain what the behavior is now, and also act as a verification of what is different after any changes we make to fix it.

@mkilgore mkilgore added the bug Something isn't working label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant