Merge pull request #548 from QB64-Phoenix-Edition/deprecation-finetuning

Finalize $NOPREFIX deprecation

Author: RhoSigma-QB64

source/qb64pe.bas

@@ -1643,6 +1643,11 @@ DO
             END IF
         END IF
 
+        IF temp$ = "$NOPREFIX" THEN
+            a$ = "$NOPREFIX is a deprecated feature, QB64(PE) specific keywords MUST have the underscore"
+            GOTO errmes
+        END IF
+
         IF LEFT$(temp$, 7) = "$ERROR " THEN
             temp$ = RemoveStringEnclosingPair(LTRIM$(MID$(temp$, 7)), METACOMMAND_STRING_ENCLOSING_PAIR)
             a$ = "Compilation check failed: " + temp$
@@ -1712,6 +1717,11 @@ DO
             END SELECT
         END IF
 
+        IF LEFT$(temp$, 15) = "$MIDISOUNDFONT:" THEN
+            a$ = "$MIDISOUNDFONT is a deprecated keyword, use _MIDISOUNDBANK instead"
+            GOTO errmes
+        END IF
+
         wholeline$ = lineformat(wholeline$)
         IF Error_Happened THEN GOTO errmes
 
@@ -2958,32 +2968,12 @@ DO
             GOTO finishednonexec
         END IF
 
-        IF a3u$ = "$NOPREFIX" THEN
-            'Deprecated; does nothing.
-            layout$ = SCase$("$NoPrefix")
-            addWarning linenumber, inclevel, inclinenumber(inclevel), incname$(inclevel), "Deprecated feature", "$NOPREFIX"
-            GOTO finishednonexec
-        END IF
-
         IF a3u$ = "$INCLUDEONCE" THEN
             'just to catch it as keyword
             layout$ = SCase$("$IncludeOnce")
             GOTO finishednonexec
         END IF
 
-        IF a3u$ = "$VIRTUALKEYBOARD:ON" THEN
-            'Deprecated; does nothing.
-            layout$ = SCase$("$VirtualKeyboard:On")
-            addWarning linenumber, inclevel, inclinenumber(inclevel), incname$(inclevel), "Deprecated feature", "$VIRTUALKEYBOARD"
-            GOTO finishednonexec
-        END IF
-        IF a3u$ = "$VIRTUALKEYBOARD:OFF" THEN
-            'Deprecated; does nothing.
-            layout$ = SCase$("$VirtualKeyboard:Off")
-            addWarning linenumber, inclevel, inclinenumber(inclevel), incname$(inclevel), "Deprecated feature", "$VIRTUALKEYBOARD"
-            GOTO finishednonexec
-        END IF
-
         IF a3u$ = "$DEBUG" THEN
             layout$ = SCase$("$Debug")
             IF NoIDEMode THEN
@@ -3213,7 +3203,7 @@ DO
             FOR i = 2 TO LEN(EmbedHandle$)
                 SELECT CASE ASC(EmbedHandle$, i)
                     CASE 0 TO 47, 58 TO 64, 91 TO 96, 123 TO 255
-                        a$ = "Embed-Handle '" + EmbedHandle$ + "' has invalid chars, use A-Z/a-z/0-9 only": GOTO errmes
+                        a$ = "Embed-Handle '" + EmbedHandle$ + "' has invalid chars, use Aa-Zz/0-9 only": GOTO errmes
                 END SELECT
             NEXT i
             'check for duplicate definitions
@@ -3305,7 +3295,7 @@ DO
             SELECT CASE token$
                 CASE "MIDI"
                     layout$ = layout$ + SCase$("Midi")
-                    addWarning linenumber, inclevel, inclinenumber(inclevel), incname$(inclevel), "Deprecated feature, use _MIDISOUNDBANK instead", "$UNSTABLE:MIDI"
+                    addWarning linenumber, inclevel, inclinenumber(inclevel), incname$(inclevel), "No longer required, feature is stable now", "$UNSTABLE:MIDI"
 
                 CASE "HTTP"
                     layout$ = layout$ + SCase$("Http")
@@ -3314,15 +3304,6 @@ DO
             GOTO finishednonexec
         END IF
 
-        IF unstableFlags(UNSTABLE_MIDI) THEN
-            IF LEFT$(a3u$, 15) = "$MIDISOUNDFONT:" THEN
-                layout$ = SCase$("$MIDISoundFont:") + MID$(a3$, 16)
-                addWarning linenumber, inclevel, inclinenumber(inclevel), incname$(inclevel), "Deprecated feature, use _MIDISOUNDBANK instead", "$MIDISOUNDFONT"
-
-                GOTO finishednonexec
-            END IF
-        END IF
-
     END IF 'QB64 Metacommands
 
     IF ExecLevel(ExecCounter) THEN

source/subs_functions/syntax_highlighter_list.bas

@@ -2,10 +2,9 @@ $CONSOLE:ONLY
 _DEST _CONSOLE
 CHDIR _STARTDIR$
 
-$Unstable: Midi
-$MidiSoundFont: Default
+_MIDISOUNDBANK "./test-soundfont.sf2"
 
-handle = _SndOpen("./midi.mid")
+handle = _SNDOPEN("./midi.mid")
 
-print handle;
+PRINT handle;
 SYSTEM