Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation in weak OT solver #404

Closed
jvlindheim opened this issue Oct 27, 2022 · 1 comment · Fixed by #410
Closed

Wrong documentation in weak OT solver #404

jvlindheim opened this issue Oct 27, 2022 · 1 comment · Fixed by #410

Comments

@jvlindheim
Copy link

Thanks for the addition of the weak OT solver this year!

I just wanted to comment on the docstring of this function. To my understanding, there is an error in the statement of the problem that is solved: The quadratic losses should be weighted by the source sample weights. Furthermore, there is a Latex error because of a missing space.
Finally, I would add G0 to the list of parameters.

@rflamary
Copy link
Collaborator

Hello @jvlindheim those arer all good points. Feel free to propose a PR to correct the documentation. This is good timing the weke OT solver has not been released officially yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants