Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLACheckpointIO #9972

Merged
merged 7 commits into from
Oct 20, 2021
Merged

Add XLACheckpointIO #9972

merged 7 commits into from
Oct 20, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Oct 17, 2021

What does this PR do?

Add XLACheckpointIO plugin

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this Oct 20, 2021
@kaushikb11 kaushikb11 added feature Is an improvement or enhancement accelerator: tpu Tensor Processing Unit labels Oct 20, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Oct 20, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review October 20, 2021 16:16
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

tests/accelerators/test_tpu.py Show resolved Hide resolved
pytorch_lightning/plugins/io/xla_plugin.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #9972 (4540487) into master (0b68f2a) will decrease coverage by 0%.
The diff coverage is 73%.

@@          Coverage Diff           @@
##           master   #9972   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         180     181    +1     
  Lines       15869   15918   +49     
======================================
+ Hits        14686   14731   +45     
- Misses       1183    1187    +4     

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@kaushikb11 kaushikb11 merged commit aa15404 into master Oct 20, 2021
@kaushikb11 kaushikb11 deleted the tpu/checkpoint_io branch October 20, 2021 21:09
awaelchli added a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants