-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
del iterator on_run_end() #9915
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9915 +/- ##
======================================
- Coverage 89% 89% -0%
======================================
Files 180 180
Lines 16147 16188 +41
======================================
+ Hits 14318 14335 +17
- Misses 1829 1853 +24 |
Can someone please re-run the failing build? I don't have permission to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed back the test as we want to make sure we shutdown the workers.
@carmocca Should we kill the workers only on the latest epoch ? |
(Be sure to clean up even if training/inference is aborted due to an exception) |
What does this PR do?
Fixes #9390
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃