Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to check for spawn in worker_check #9902

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 12, 2021

What does this PR do?

Checking for spawn using this using_spawn = self.accelerator_connector.distributed_backend == "ddp_spawn" isn't
correct here because we turn of spawn if num_processes < 2 which is the case the test was running on and was still raising the warning which it shouldn't:
https://github.com/PyTorchLightning/pytorch-lightning/blob/4610fddb19d502e534b5c5d77c3dfd6f2e5359a5/pytorch_lightning/trainer/connectors/accelerator_connector.py#L790-L800

this PR just fixes that

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7
Copy link
Contributor Author

the issue for failing test is that it's now actually running spawn process and we need to catch some warnings. have tried everything, but couldn't find a way.. feel free to commit.. any help would be appreciated :) thank you

@rohitgr7 rohitgr7 added the bug Something isn't working label Oct 17, 2021
@rohitgr7 rohitgr7 added this to the v1.4.x milestone Oct 17, 2021
@rohitgr7 rohitgr7 force-pushed the tests/cpu_ddp_spawn branch from c9531f8 to 00a93f9 Compare October 17, 2021 19:50
@rohitgr7 rohitgr7 marked this pull request as ready for review October 17, 2021 19:51
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@rohitgr7 rohitgr7 self-assigned this Oct 17, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #9902 (22cceb4) into master (7b4df7b) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9902   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         179     179           
  Lines       15839   15825   -14     
======================================
- Hits        14679   14661   -18     
- Misses       1160    1164    +4     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 18, 2021
@awaelchli awaelchli modified the milestones: v1.4.x, v1.5 Oct 18, 2021
tests/trainer/test_data_loading.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 18, 2021 12:33
@rohitgr7 rohitgr7 merged commit 4dc32ad into master Oct 18, 2021
@rohitgr7 rohitgr7 deleted the tests/cpu_ddp_spawn branch October 18, 2021 13:02
rohitgr7 added a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
* fix

* update tests

* chlog

* skip windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants