-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic to check for spawn in worker_check #9902
Conversation
the issue for failing test is that it's now actually running spawn process and we need to catch some warnings. have tried everything, but couldn't find a way.. feel free to commit.. any help would be appreciated :) thank you |
c9531f8
to
00a93f9
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Codecov Report
@@ Coverage Diff @@
## master #9902 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 179 179
Lines 15839 15825 -14
======================================
- Hits 14679 14661 -18
- Misses 1160 1164 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
* fix * update tests * chlog * skip windows
What does this PR do?
Checking for spawn using this
using_spawn = self.accelerator_connector.distributed_backend == "ddp_spawn"
isn'tcorrect here because we turn of spawn if
num_processes < 2
which is the case the test was running on and was still raising the warning which it shouldn't:https://github.com/PyTorchLightning/pytorch-lightning/blob/4610fddb19d502e534b5c5d77c3dfd6f2e5359a5/pytorch_lightning/trainer/connectors/accelerator_connector.py#L790-L800
this PR just fixes that
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃