Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for pl.utilities.grads #9765

Merged
merged 8 commits into from
Oct 18, 2021
Merged

add unit tests for pl.utilities.grads #9765

merged 8 commits into from
Oct 18, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 29, 2021

What does this PR do?

Adds tests and coverage for pytorch_lightning.utilities.grads.grad_norm function.
Found an edge case where L0 "norm" (p=0) does not yield the correct result for the total norm. This is because the implementation of the total norm there only works for proper norms (the L0 is not a real norm).

Option A: special case the L0 norm computation
Option B: don't support norm_type=0

Related PR: #9742

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Sep 29, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 29, 2021
@awaelchli awaelchli marked this pull request as ready for review October 11, 2021 14:45
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #9765 (428055b) into master (a002f87) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9765   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15803   15805    +2     
======================================
+ Hits        14647   14649    +2     
  Misses       1156    1156           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Good catch !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Oct 14, 2021
@carmocca carmocca enabled auto-merge (squash) October 14, 2021 21:00
@carmocca carmocca mentioned this pull request Oct 18, 2021
9 tasks
@carmocca carmocca merged commit a99b744 into master Oct 18, 2021
@carmocca carmocca deleted the tests/grad-norm branch October 18, 2021 13:28
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants