Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a unique filename to save temp ckpt in tuner #9682

Merged
merged 3 commits into from
Sep 25, 2021
Merged

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Fixes #9574

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 marked this pull request as ready for review September 24, 2021 08:52
@rohitgr7 rohitgr7 added the tuner label Sep 24, 2021
@rohitgr7 rohitgr7 added this to the v1.4.x milestone Sep 24, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/tuner/lr_finder.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) September 24, 2021 11:09
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #9682 (44b1c25) into master (41e3be1) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9682   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15306   15308    +2     
======================================
+ Hits        14199   14201    +2     
  Misses       1107    1107           

@rohitgr7 rohitgr7 merged commit a3def9d into master Sep 25, 2021
@rohitgr7 rohitgr7 deleted the ref/tuner_fname branch September 25, 2021 11:28
@awaelchli awaelchli modified the milestones: v1.4.x, v1.5 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lr_find need unique temporary checkpoint filenames.
6 participants