Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove InternalDebugger #9680

Merged
merged 17 commits into from
Sep 27, 2021
Merged

remove InternalDebugger #9680

merged 17 commits into from
Sep 27, 2021

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Fixes #9661

Follow up to #9675

What does this PR do?

Fixes

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added ci Continuous Integration refactor labels Sep 24, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 24, 2021
@awaelchli awaelchli changed the title remove InternalDebugger remove InternalDebugger Sep 24, 2021
Base automatically changed from feature/dev_debugger/remove-dl to master September 24, 2021 13:37
@carmocca carmocca marked this pull request as ready for review September 24, 2021 13:39
@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #9680 (3999251) into master (d67aff7) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9680   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     178    -1     
  Lines       15280   15261   -19     
======================================
- Hits        14169   14156   -13     
+ Misses       1111    1105    -6     

@carmocca carmocca enabled auto-merge (squash) September 24, 2021 15:49
@awaelchli awaelchli added the admin Requires admin privileges to merge label Sep 27, 2021
@lexierule lexierule disabled auto-merge September 27, 2021 13:33
@lexierule lexierule merged commit f74eb58 into master Sep 27, 2021
@lexierule lexierule deleted the feature/dev_debugger/remove branch September 27, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Requires admin privileges to merge ci Continuous Integration ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove InternalDebugger
6 participants