Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use completed over processed in reset_on_restart #9656

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Requested by @tchaton

This was originally added in #8334

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9656 (34bfbf8) into master (4bebf82) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 34bfbf8 differs from pull request most recent head 5feaa54. Consider uploading reports for the commit 5feaa54 to get more accurate results

@@          Coverage Diff           @@
##           master   #9656   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15305   15307    +2     
======================================
+ Hits        14197   14200    +3     
+ Misses       1108    1107    -1     

@carmocca carmocca added progress tracking (internal) Related to the progress tracking dataclasses and removed fault tolerance labels Sep 23, 2021
@carmocca carmocca enabled auto-merge (squash) September 23, 2021 01:48
@mergify mergify bot added the ready PRs ready to be merged label Sep 23, 2021
@carmocca carmocca merged commit ca5459e into master Sep 23, 2021
@carmocca carmocca deleted the refactor/use-completed-reset-on-restart branch September 23, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress tracking (internal) Related to the progress tracking dataclasses ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants