-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warnings in TrainingTricksConnector
#9595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
September 24, 2021 08:07
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Codecov Report
@@ Coverage Diff @@
## master #9595 +/- ##
=======================================
+ Coverage 92% 93% +1%
=======================================
Files 181 179 -2
Lines 15728 15317 -411
=======================================
- Hits 14446 14209 -237
+ Misses 1282 1108 -174 |
tchaton
reviewed
Sep 24, 2021
pytorch_lightning/trainer/connectors/training_trick_connector.py
Outdated
Show resolved
Hide resolved
SkafteNicki
approved these changes
Sep 24, 2021
pytorch_lightning/trainer/connectors/training_trick_connector.py
Outdated
Show resolved
Hide resolved
awaelchli
reviewed
Sep 24, 2021
pytorch_lightning/trainer/connectors/training_trick_connector.py
Outdated
Show resolved
Hide resolved
rohitgr7
commented
Sep 24, 2021
pytorch_lightning/trainer/connectors/training_trick_connector.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/trainer/connectors/training_trick_connector.py
Outdated
Show resolved
Hide resolved
rohitgr7
commented
Sep 24, 2021
carmocca
reviewed
Sep 24, 2021
carmocca
approved these changes
Sep 24, 2021
ananthsub
reviewed
Sep 24, 2021
pytorch_lightning/trainer/connectors/training_trick_connector.py
Outdated
Show resolved
Hide resolved
awaelchli
approved these changes
Sep 25, 2021
ananthsub
approved these changes
Sep 25, 2021
speediedan
pushed a commit
to speediedan/lightning
that referenced
this pull request
Sep 28, 2021
* update warnings * add tests * comments * Apply suggestions from code review * Apply suggestions from code review
awaelchli
added a commit
that referenced
this pull request
Sep 29, 2021
Co-authored-by: Rohit Gupta <[email protected]>
awaelchli
added a commit
that referenced
this pull request
Sep 29, 2021
Co-authored-by: Rohit Gupta <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Sep 30, 2021
Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improved some warnings and checks since there is some ambiguity.
Now both 'Norm' and 'norm' are valid
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?