Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle collision of user argument when using ShardedDDP #9512

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 14, 2021

What does this PR do?

Ensure that if a user passes reduce_buffer_size manually, we handle this case appropriately, i.e:

plugin = DDPShardedPlugin(reduce_buffer_size=1e8)

Related #9483

cc @ananthsub

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug Something isn't working label Sep 14, 2021
@SeanNaren SeanNaren added this to the v1.4.x milestone Sep 14, 2021
@SeanNaren SeanNaren self-assigned this Sep 14, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 14, 2021
@justusschock justusschock enabled auto-merge (squash) September 14, 2021 11:55
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #9512 (779abcf) into master (c784092) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9512   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         180     180           
  Lines       15072   15074    +2     
======================================
+ Hits        13997   13999    +2     
  Misses       1075    1075           

@justusschock justusschock merged commit adaa234 into master Sep 14, 2021
@justusschock justusschock deleted the fix/reduce_buffer_size branch September 14, 2021 12:20
ethanwharris pushed a commit that referenced this pull request Sep 14, 2021
* Handle collision of user argument

* Add CHANGELOG.md
lexierule pushed a commit that referenced this pull request Sep 15, 2021
* Handle collision of user argument

* Add CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants