Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass args to ShardedDataParallel #9483

Merged
merged 5 commits into from
Sep 13, 2021
Merged

Pass args to ShardedDataParallel #9483

merged 5 commits into from
Sep 13, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 13, 2021

What does this PR do?

Fixes #9467

Pass kwargs to wrapper, just like DDP does with DDP wrapper

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug Something isn't working label Sep 13, 2021
@SeanNaren SeanNaren added this to the v1.4.x milestone Sep 13, 2021
@SeanNaren SeanNaren self-assigned this Sep 13, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) September 13, 2021 10:54
@mergify mergify bot added the ready PRs ready to be merged label Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #9483 (906f970) into master (07e94b8) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9483   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         180     180           
  Lines       15066   15066           
======================================
+ Hits        13986   13991    +5     
+ Misses       1080    1075    -5     

@SeanNaren SeanNaren merged commit ec828b8 into master Sep 13, 2021
@SeanNaren SeanNaren deleted the fix/kwargs_sharded branch September 13, 2021 15:18
@@ -41,6 +41,7 @@ def configure_ddp(self) -> None:
sharded_optimizer=self.lightning_module.trainer.optimizers,
# For multi-node training, enabling bucketing will improve performance.
reduce_buffer_size=self._REDUCE_BUFFER_SIZE_DEFAULT if self.num_nodes > 1 else 0,
**self._ddp_kwargs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanNaren should we explicitly check if reduce_buffer_size is part of the kwargs to avoid errors with it being configured twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great point, will do a followup here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kwargs from DDPShardedPlugin are not forwarded to the ShardedDataParallel wrapper
6 participants