Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Always return batch indices to prevent duplicated logic for the users #9432

Merged
merged 8 commits into from
Sep 14, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 10, 2021

What does this PR do?

Fixes #9425

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Sep 10, 2021
@tchaton tchaton added the bug Something isn't working label Sep 10, 2021
@tchaton tchaton added this to the v1.4.x milestone Sep 10, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/prediction_epoch_loop.py Outdated Show resolved Hide resolved
@awaelchli awaelchli self-requested a review September 10, 2021 22:47
@mergify mergify bot added the ready PRs ready to be merged label Sep 10, 2021
@tchaton tchaton enabled auto-merge (squash) September 14, 2021 11:39
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #9432 (30cfc9d) into master (03c762c) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9432   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         180     180           
  Lines       15077   15107   +30     
======================================
+ Hits        13382   13420   +38     
+ Misses       1695    1687    -8     

@mergify mergify bot removed the has conflicts label Sep 14, 2021
@tchaton tchaton merged commit 1814334 into master Sep 14, 2021
@tchaton tchaton deleted the fix_bug branch September 14, 2021 14:40
ethanwharris pushed a commit that referenced this pull request Sep 14, 2021
@ethanwharris ethanwharris modified the milestones: v1.4.x, v1.5 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gap in IndexBatchSamplerWrapper check for dataloaders used for prediction
7 participants