Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert state to tuple explicitly when setting python random state #9401

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 9, 2021

What does this PR do?

Fixes #9400

The changes in this PR should be a no-op as the state should already be a tuple. #9400 was reported on slack, not reproducible, but adding the tuple conversion doesn't hurt and resolves a user's issue for testing out the FT feature.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
    For the reason outlined above, no
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli changed the title convert state to tuple explicitly convert state to tuple explicitly when setting python random state Sep 9, 2021
@awaelchli awaelchli added the bug Something isn't working label Sep 9, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli marked this pull request as ready for review September 9, 2021 12:46
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2021
@SeanNaren SeanNaren merged commit 089ae9b into master Sep 9, 2021
@SeanNaren SeanNaren deleted the bufix/force-tuple-conversion branch September 9, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python random.setstate type error when resuming from fault-tolerant training
4 participants