Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_checkpoint to CheckpointIO plugin to simplify ModelCheckpo… #9373

Merged
merged 6 commits into from
Sep 10, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Sep 8, 2021

…int Callback

What does this PR do?

There are two parts to #9074

  1. Moving remove_checkpoint responsibility from the ModelCheckpoint callback to CheckpointIO plugin, also a few more IO operations such as creating directories, etc.
  2. Deprecating the should_rank_save_save_checkpoint property

Fixes part 1 of #9074

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this Sep 9, 2021
@kaushikb11 kaushikb11 added feature Is an improvement or enhancement refactor labels Sep 9, 2021
Co-authored-by: ananthsub <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #9373 (fc4f6f8) into master (3070a9e) will decrease coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9373    +/-   ##
=======================================
- Coverage      92%     89%    -3%     
=======================================
  Files         179     179            
  Lines       14904   14934    +30     
=======================================
- Hits        13750   13262   -488     
- Misses       1154    1672   +518     

@ananthsub ananthsub added the checkpointing Related to checkpointing label Sep 9, 2021
@tchaton tchaton merged commit d028e36 into master Sep 10, 2021
@tchaton tchaton deleted the simplify/model_checkpoint branch September 10, 2021 10:55
@ethanwharris ethanwharris added this to the v1.5 milestone Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants