-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove_checkpoint to CheckpointIO plugin to simplify ModelCheckpo… #9373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
reviewed
Sep 9, 2021
SeanNaren
approved these changes
Sep 9, 2021
ananthsub
reviewed
Sep 9, 2021
Co-authored-by: ananthsub <[email protected]>
carmocca
approved these changes
Sep 9, 2021
SeanNaren
approved these changes
Sep 9, 2021
ananthsub
approved these changes
Sep 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #9373 +/- ##
=======================================
- Coverage 92% 89% -3%
=======================================
Files 179 179
Lines 14904 14934 +30
=======================================
- Hits 13750 13262 -488
- Misses 1154 1672 +518 |
awaelchli
approved these changes
Sep 9, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checkpointing
Related to checkpointing
feature
Is an improvement or enhancement
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…int Callback
What does this PR do?
There are two parts to #9074
remove_checkpoint
responsibility from theModelCheckpoint
callback toCheckpointIO
plugin, also a few more IO operations such as creating directories, etc.should_rank_save_save_checkpoint
propertyFixes part 1 of #9074
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃