-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradient norm tracking and gradient clipping #9287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Sep 2, 2021
16 tasks
carmocca
changed the title
[WIP] Fix gradient norm tracking and gradient clipping
[WIP] Fix gradient norm tracking and gradient clipping [2/2]
Sep 2, 2021
carmocca
changed the base branch from
master
to
bugfix/plugin-closure-execution
September 6, 2021 21:30
carmocca
requested review from
Borda,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 27, 2021 01:27
carmocca
commented
Oct 27, 2021
carmocca
commented
Oct 27, 2021
tchaton
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
awaelchli
approved these changes
Oct 27, 2021
rohitgr7
reviewed
Oct 27, 2021
Borda
approved these changes
Oct 27, 2021
Co-authored-by: Rohit Gupta <[email protected]>
rohitgr7
approved these changes
Oct 27, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9599, #9330, #9205, #9694
Before:
After:
Zero will happen on the next step so the gradients will not have been zero-ed out
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review