-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for uninitialized _sync_dir
in DDP Plugin to avoid errors during error handling
#9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
September 2, 2021 01:40
four4fish
changed the title
fix reconciliate processes masks errors in DDP plugin if _sync_dir is…
Fix reconciliate processes masks errors in DDP plugin if _sync_dir isn't initialized
Sep 2, 2021
four4fish
requested review from
Borda,
carmocca,
kaushikb11 and
williamFalcon
as code owners
September 2, 2021 01:43
ananthsub
added
distributed
Generic distributed-related topic
bug
Something isn't working
labels
Sep 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #9267 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 178 +2
Lines 14810 14854 +44
=======================================
- Hits 13662 13088 -574
- Misses 1148 1766 +618 |
ananthsub
approved these changes
Sep 2, 2021
carmocca
approved these changes
Sep 2, 2021
ananthsub
changed the title
Fix reconciliate processes masks errors in DDP plugin if _sync_dir isn't initialized
Add check for uninitialized Sep 2, 2021
_sync_dir
in DDP Plugin to avoid errors during error handling
tchaton
reviewed
Sep 2, 2021
awaelchli
approved these changes
Sep 2, 2021
SeanNaren
approved these changes
Sep 2, 2021
…uring error handling
justusschock
pushed a commit
that referenced
this pull request
Sep 7, 2021
…uring error handling (#9267)
awaelchli
pushed a commit
that referenced
this pull request
Sep 7, 2021
…uring error handling (#9267)
lexierule
pushed a commit
that referenced
this pull request
Sep 10, 2021
…uring error handling (#9267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
python -m pytest -v tests/trainer. passed
python -m pytest -v tests/plugins. passed
python -m pytest -v tests/accelerators. passed
Fixes #9263
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃