Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for uninitialized _sync_dir in DDP Plugin to avoid errors during error handling #9267

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Sep 2, 2021

What does this PR do?

python -m pytest -v tests/trainer. passed
python -m pytest -v tests/plugins. passed
python -m pytest -v tests/accelerators. passed

Fixes #9263

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish changed the title fix reconciliate processes masks errors in DDP plugin if _sync_dir is… Fix reconciliate processes masks errors in DDP plugin if _sync_dir isn't initialized Sep 2, 2021
@four4fish
Copy link
Contributor Author

@ananthsub

@ananthsub ananthsub added distributed Generic distributed-related topic bug Something isn't working labels Sep 2, 2021
@ananthsub ananthsub added this to the v1.4.x milestone Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #9267 (7753b4b) into master (f9994d4) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9267    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     178     +2     
  Lines       14810   14854    +44     
=======================================
- Hits        13662   13088   -574     
- Misses       1148    1766   +618     

pytorch_lightning/plugins/training_type/ddp.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/ddp.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 2, 2021
@ananthsub ananthsub changed the title Fix reconciliate processes masks errors in DDP plugin if _sync_dir isn't initialized Add check for uninitialized _sync_dir in DDP Plugin to avoid errors during error handling Sep 2, 2021
@ananthsub ananthsub merged commit 69cdb79 into Lightning-AI:master Sep 2, 2021
justusschock pushed a commit that referenced this pull request Sep 7, 2021
Borda pushed a commit that referenced this pull request Sep 7, 2021
awaelchli pushed a commit that referenced this pull request Sep 7, 2021
lexierule pushed a commit that referenced this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconciliate processes masks errors in DDP plugin if _sync_dir isn't initialized
6 participants