Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate process_position from the Trainer constructor #9222

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Fixes #8968

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added design Includes a design discussion deprecation Includes a deprecation labels Aug 31, 2021
@kaushikb11 kaushikb11 self-assigned this Aug 31, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/callback_connector.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #9222 (7ec5cb7) into master (f6614b3) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9222   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         176     176           
  Lines       14805   14806    +1     
======================================
+ Hits        13658   13659    +1     
  Misses       1147    1147           

@kaushikb11 kaushikb11 enabled auto-merge (squash) August 31, 2021 13:01
@kaushikb11 kaushikb11 merged commit f21f1be into master Aug 31, 2021
@kaushikb11 kaushikb11 deleted the deprecate/process_position branch August 31, 2021 15:14
@ananthsub
Copy link
Contributor

thanks @kaushikb11 !

@ethanwharris ethanwharris added this to the v1.5 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation design Includes a design discussion ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate process_position from the Trainer constructor
5 participants