-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate process_position
from the Trainer constructor
#9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
added
design
Includes a design discussion
deprecation
Includes a deprecation
labels
Aug 31, 2021
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren and
tchaton
as code owners
August 31, 2021 10:22
tchaton
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
approved these changes
Aug 31, 2021
ethanwharris
approved these changes
Aug 31, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9222 +/- ##
======================================
Coverage 92% 92%
======================================
Files 176 176
Lines 14805 14806 +1
======================================
+ Hits 13658 13659 +1
Misses 1147 1147 |
thanks @kaushikb11 ! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8968
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃