Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning to deepspeed when inferring batch size #9221

Merged
merged 8 commits into from
Sep 7, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 31, 2021

What does this PR do?

Closes #8872

Adds a warning for users, as this may crash their code if they require setup to be called first.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the feature Is an improvement or enhancement label Aug 31, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Aug 31, 2021
@SeanNaren SeanNaren self-assigned this Aug 31, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #9221 (7b1c15f) into master (6892d53) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9221    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         178     178            
  Lines       14899   14899            
=======================================
- Hits        13752   13139   -613     
- Misses       1147    1760   +613     

@mergify mergify bot added the has conflicts label Sep 1, 2021
@mergify mergify bot removed the has conflicts label Sep 2, 2021
tests/plugins/test_deepspeed_plugin.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 7, 2021
@mergify mergify bot added the has conflicts label Sep 7, 2021
@mergify mergify bot removed the has conflicts label Sep 7, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) September 7, 2021 15:33
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment 😃

pytorch_lightning/plugins/training_type/deepspeed.py Outdated Show resolved Hide resolved
@SeanNaren SeanNaren merged commit a79c351 into master Sep 7, 2021
@SeanNaren SeanNaren deleted the fix/add_warning_deepspeed branch September 7, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deepspeed accelerator calls datamodule.train_dataloader() prior to setup()
5 participants