Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated property ModelCheckpoint.period in favor of ModelCheckpoint.every_n_epochs #9213

Merged

Conversation

Tshimanga
Copy link
Contributor

@Tshimanga Tshimanga commented Aug 31, 2021

What does this PR do?

Removal of ModelCheckpoint.period in favor of ModelCheckpoint.every_n_epochs as scheduled for 1.5

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added breaking change Includes a breaking change checkpointing Related to checkpointing deprecation Includes a deprecation labels Aug 31, 2021
@carmocca carmocca added this to the v1.5 milestone Aug 31, 2021
@carmocca carmocca changed the title Removal/1.5 model checkpoint period Remove deprecated property ModelCheckpoint.period in favor of ModelCheckpoint.every_n_epochs Aug 31, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort!

CHANGELOG.md Show resolved Hide resolved
@Tshimanga
Copy link
Contributor Author

@carmocca let me know if you guys want a @every_n_epochs.setter as well. I didn't see any functionality depending on @period.setter anywhere so I left that one out

@carmocca
Copy link
Contributor

@carmocca let me know if you guys want a @every_n_epochs.setter as well. I didn't see any functionality depending on @period.setter anywhere so I left that one out

I thought about it and I don't think we should add it, as there's some post-processing on it (__init_triggers and __validate_init_configuration) so we don't want users to change the value after __init__

@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2021
@awaelchli awaelchli merged commit 07ee8fc into Lightning-AI:master Aug 31, 2021
@Tshimanga Tshimanga deleted the removal/1.5-model-checkpoint-period branch August 31, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change checkpointing Related to checkpointing deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants