Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BasePlugin #9066

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Remove BasePlugin #9066

merged 3 commits into from
Aug 25, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Aug 23, 2021

What does this PR do?

deprecate unnecessary interface, flatten plugins

Next step : Unify TrainingTypePlugin and PrecisionPlugin interface

Tests:
python -m pytest -v tests/trainer. passed
python -m pytest -v tests/plugins passed

Fixes #8988

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #9066 (c5174ad) into master (de57fef) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9066    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     175     -1     
  Lines       14663   14665     +2     
=======================================
- Hits        13496   12888   -608     
- Misses       1167    1777   +610     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove it directly.

pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/precision_plugin.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change labels Aug 23, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 23, 2021
@awaelchli
Copy link
Contributor

@four4fish do you have any details on

Next step : Unify TrainingTypePlugin and PrecisionPlugin interface

Let's discuss on a GitHub issue?

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss on a GitHub issue?

+1 - let's use this issue to discuss the new proposal: #7324

@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2021
@mergify mergify bot removed the has conflicts label Aug 25, 2021
@ananthsub ananthsub changed the title Deprecate the BasePlugin Remove BasePlugin Aug 25, 2021
@ananthsub ananthsub enabled auto-merge (squash) August 25, 2021 18:55
@ananthsub ananthsub merged commit f01a9a6 into Lightning-AI:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the BasePlugin
6 participants