-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BasePlugin
#9066
Remove BasePlugin
#9066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9066 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 175 -1
Lines 14663 14665 +2
=======================================
- Hits 13496 12888 -608
- Misses 1167 1777 +610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove it directly.
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
@four4fish do you have any details on
Let's discuss on a GitHub issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss on a GitHub issue?
+1 - let's use this issue to discuss the new proposal: #7324
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
Co-authored-by: ananthsub <[email protected]>
What does this PR do?
deprecate unnecessary interface, flatten plugins
Next step : Unify TrainingTypePlugin and PrecisionPlugin interface
Tests:
python -m pytest -v tests/trainer. passed
python -m pytest -v tests/plugins passed
Fixes #8988
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃