Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1/n inter batch parallelism #9020

Merged
merged 18 commits into from
Aug 23, 2021
Merged

1/n inter batch parallelism #9020

merged 18 commits into from
Aug 23, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 20, 2021

What does this PR do?

This PR introduce the first component from #8959

Parts #8867
Parts #8316

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #9020 (2f305b0) into master (0461107) will increase coverage by 0%.
The diff coverage is 97%.

@@          Coverage Diff           @@
##           master   #9020   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         175     175           
  Lines       14361   14454   +93     
======================================
+ Hits        13312   13402   +90     
- Misses       1049    1052    +3     

@tchaton tchaton marked this pull request as ready for review August 20, 2021 18:13
@tchaton tchaton added the feature Is an improvement or enhancement label Aug 20, 2021
@tchaton tchaton modified the milestones: v1.4.x, v1.5 Aug 20, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments

pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/training_epoch_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
tests/utilities/test_fetching.py Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 23, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but the added test time is concerning me

tests/utilities/test_fetching.py Outdated Show resolved Hide resolved
tests/utilities/test_fetching.py Outdated Show resolved Hide resolved
tests/utilities/test_fetching.py Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) August 23, 2021 12:37
@tchaton tchaton merged commit e9ce598 into master Aug 23, 2021
@tchaton tchaton deleted the 1/n_inter_batch_parallelism branch August 23, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants