-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1/n inter batch parallelism #9020
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9020 +/- ##
======================================
Coverage 93% 93%
======================================
Files 175 175
Lines 14361 14454 +93
======================================
+ Hits 13312 13402 +90
- Misses 1049 1052 +3 |
…rchLightning/pytorch-lightning into 1/n_inter_batch_parallelism
…lightning into 0/n_inter_batch_parallelism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comments
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but the added test time is concerning me
What does this PR do?
This PR introduce the first component from #8959
Parts #8867
Parts #8316
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃