Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions from accelerator.py #9019

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Aug 20, 2021

What does this PR do?

function connect_precision_plugin and connect_training_type_plugin has been deprecated in v1.3, remove them in v1.5

Fixes #9018

Does your PR introduce any breaking changes? If yes, please list them.

Removes connect_precision_plugin and connect_training_type_plugin from the Accelerator API

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #9019 (0843eb4) into master (e1442d2) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9019    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         175     175            
  Lines       14398   14395     -3     
=======================================
- Hits        13337   12756   -581     
- Misses       1061    1639   +578     

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup! please add to the changelog too

@ananthsub ananthsub changed the title Remove deprecated funcstions from accelerator.py Remove deprecated functions from accelerator.py Aug 20, 2021
@ananthsub ananthsub added breaking change Includes a breaking change refactor ready PRs ready to be merged labels Aug 20, 2021
@awaelchli awaelchli merged commit 13e64e6 into Lightning-AI:master Aug 21, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated function connect_precision_plugin and connect_training_type_plugin
4 participants