Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the existence of DDPPlugin._sync_dir in reconciliate_processes #8939

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

yifuwang
Copy link
Contributor

@yifuwang yifuwang commented Aug 16, 2021

What does this PR do?

Fixes #8938

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #8939 (7a7aff8) into master (89156b7) will decrease coverage by 4%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #8939    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         173     173            
  Lines       14182   14184     +2     
=======================================
- Hits        13174   12597   -577     
- Misses       1008    1587   +579     

@yifuwang yifuwang changed the title Ensure the existence of DDPPlugin._sync_dir in reconciliate_processes Ensure the existence of DDPPlugin._sync_dir in reconciliate_processes Aug 16, 2021
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ananthsub ananthsub added bug Something isn't working distributed Generic distributed-related topic labels Aug 16, 2021
@ananthsub ananthsub added this to the v1.4.x milestone Aug 16, 2021
@ananthsub ananthsub added the ready PRs ready to be merged label Aug 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting !

@kaushikb11 kaushikb11 merged commit 14f1475 into Lightning-AI:master Aug 17, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Aug 18, 2021
lexierule pushed a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDPPlugin.reconciliate_processes fails on clusters that periodically purges the /tmp
4 participants