-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the existence of DDPPlugin._sync_dir
in reconciliate_processes
#8939
Merged
kaushikb11
merged 2 commits into
Lightning-AI:master
from
yifuwang:reconciliate_processes
Aug 17, 2021
Merged
Ensure the existence of DDPPlugin._sync_dir
in reconciliate_processes
#8939
kaushikb11
merged 2 commits into
Lightning-AI:master
from
yifuwang:reconciliate_processes
Aug 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8939 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 173 173
Lines 14182 14184 +2
=======================================
- Hits 13174 12597 -577
- Misses 1008 1587 +579 |
DDPPlugin._sync_dir
in reconciliate_processes
ananthsub
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
tchaton
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting !
kaushikb11
approved these changes
Aug 17, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Aug 18, 2021
…ses` (Lightning-AI#8939) Co-authored-by: Yifu Wang <yifuwang@[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Aug 18, 2021
…ses` (#8939) Co-authored-by: Yifu Wang <yifuwang@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8938
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃