-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep global step update in the loop #8856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Aug 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #8856 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 180 180
Lines 15062 15051 -11
=======================================
- Hits 13983 13369 -614
- Misses 1079 1682 +603 |
41c4c39
to
10045b6
Compare
10 tasks
awaelchli
approved these changes
Aug 11, 2021
tchaton
reviewed
Aug 31, 2021
carmocca
commented
Sep 11, 2021
tchaton
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Nice cleanup.
awaelchli
approved these changes
Sep 13, 2021
kaushikb11
approved these changes
Sep 14, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
design
Includes a design discussion
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The gradient accumulation logic check and global step update should be contained within the loops.
This PR changes the TTP API so that we only use it to know whether the optimization is handled internally in the case of the IPU and DeepSpeed plugins.
Does your PR introduce any breaking changes? If yes, please list them.
Beta
TrainingTypePlugin
andAccelerator
API:update_global_step
with theaccumulate_grad_batches
property.Before submitting
PR review