Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated backprop through time when set on LightningModule and not Trainer #8804

Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Aug 9, 2021

What does this PR do?

Fixes #8802

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #8804 (7887ad3) into master (f1cc6e3) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8804    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14068   14069     +1     
=======================================
- Hits        13038   12463   -575     
- Misses       1030    1606   +576     

@ananthsub ananthsub force-pushed the fix/tbptt-lightning-module-loop branch from d3e72bc to 570f6a4 Compare August 9, 2021 00:16
@ananthsub ananthsub added the bug Something isn't working label Aug 9, 2021
@ananthsub ananthsub added this to the v1.4.x milestone Aug 9, 2021
@ananthsub ananthsub force-pushed the fix/tbptt-lightning-module-loop branch from 1ba4eab to bc972b4 Compare August 9, 2021 00:31
@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tests/models/test_truncated_bptt.py Show resolved Hide resolved
@ananthsub ananthsub force-pushed the fix/tbptt-lightning-module-loop branch from 4915b95 to 7887ad3 Compare August 9, 2021 18:22
@ananthsub ananthsub enabled auto-merge (squash) August 10, 2021 04:22
@ananthsub ananthsub merged commit c4a1c8b into Lightning-AI:master Aug 10, 2021
@ananthsub ananthsub deleted the fix/tbptt-lightning-module-loop branch August 10, 2021 04:23
SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
…ot Trainer (#8804)

* Fix truncated backprop through time set on LightningModule and not Trainer

(cherry picked from commit c4a1c8b)
lexierule pushed a commit that referenced this pull request Aug 11, 2021
…ot Trainer (#8804)

* Fix truncated backprop through time set on LightningModule and not Trainer

(cherry picked from commit c4a1c8b)
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
…ot Trainer (Lightning-AI#8804)

* Fix truncated backprop through time set on LightningModule and not Trainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting lightningmodule.truncated_bptt_steps>0 will not enable tBPTT
4 participants