-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix truncated backprop through time when set on LightningModule and not Trainer #8804
Merged
ananthsub
merged 7 commits into
Lightning-AI:master
from
ananthsub:fix/tbptt-lightning-module-loop
Aug 10, 2021
Merged
Fix truncated backprop through time when set on LightningModule and not Trainer #8804
ananthsub
merged 7 commits into
Lightning-AI:master
from
ananthsub:fix/tbptt-lightning-module-loop
Aug 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
carmocca,
justusschock and
tchaton
as code owners
August 9, 2021 00:06
Codecov Report
@@ Coverage Diff @@
## master #8804 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 169 169
Lines 14068 14069 +1
=======================================
- Hits 13038 12463 -575
- Misses 1030 1606 +576 |
ananthsub
force-pushed
the
fix/tbptt-lightning-module-loop
branch
from
August 9, 2021 00:16
d3e72bc
to
570f6a4
Compare
ananthsub
requested review from
Borda,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
August 9, 2021 00:16
ananthsub
force-pushed
the
fix/tbptt-lightning-module-loop
branch
from
August 9, 2021 00:31
1ba4eab
to
bc972b4
Compare
awaelchli
approved these changes
Aug 9, 2021
carmocca
approved these changes
Aug 9, 2021
tchaton
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ananthsub
force-pushed
the
fix/tbptt-lightning-module-loop
branch
from
August 9, 2021 18:22
4915b95
to
7887ad3
Compare
12 tasks
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
…ot Trainer (Lightning-AI#8804) * Fix truncated backprop through time set on LightningModule and not Trainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8802
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃