Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments and exception message for metrics_to_scalars #8782

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

edward-io
Copy link
Contributor

What does this PR do?

Fix comments and exception string for metrics_to_scalars, which can return non-float values, such as int or complex, depending on the dtype of the tensor.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

metrics_to_scalars can return non-float values, such as int or complex, depending on the dtype of the tensor.
@Borda Borda added the docs Documentation related label Aug 6, 2021
@Borda Borda added this to the v1.4.x milestone Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #8782 (b91993b) into master (e541803) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8782    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14070   14070            
=======================================
- Hits        13040   12462   -578     
- Misses       1030    1608   +578     

@mergify mergify bot added the ready PRs ready to be merged label Aug 6, 2021
@ananthsub ananthsub enabled auto-merge (squash) August 7, 2021 04:05
@ananthsub ananthsub merged commit f3442db into Lightning-AI:master Aug 7, 2021
SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
metrics_to_scalars can return non-float values, such as int or complex, depending on the dtype of the tensor.

(cherry picked from commit f3442db)
lexierule pushed a commit that referenced this pull request Aug 11, 2021
metrics_to_scalars can return non-float values, such as int or complex, depending on the dtype of the tensor.

(cherry picked from commit f3442db)
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
metrics_to_scalars can return non-float values, such as int or complex, depending on the dtype of the tensor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants