Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo error in LightningLoggerBase.after_save_checkpoint docstring #8737

Conversation

Aiden-Jeon
Copy link
Contributor

@Aiden-Jeon Aiden-Jeon commented Aug 5, 2021

What does this PR do?

Argument and docstring args was differ in LightningLoggerBase.after_save_checkpoint.
I changed docstring with proper one

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃
-> 👍

@Aiden-Jeon Aiden-Jeon changed the title fix typo error in base.LightningLoggerBase.after_save_checkpoint docstring fix typo error in LightningLoggerBase.after_save_checkpoint docstring Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #8737 (f5c21d7) into master (963c267) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8737    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14072   14072            
=======================================
- Hits        13043   12467   -576     
- Misses       1029    1605   +576     

@ananthsub ananthsub added docs Documentation related logger Related to the Loggers labels Aug 5, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 5, 2021 07:44
@awaelchli awaelchli added this to the v1.5 milestone Aug 5, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 5, 2021
@mergify mergify bot requested a review from a team August 5, 2021 07:44
@Borda Borda modified the milestones: v1.5, v1.4.x Aug 5, 2021
@awaelchli awaelchli merged commit 1c0786e into Lightning-AI:master Aug 5, 2021
@SeanNaren SeanNaren modified the milestones: v1.4.x, v1.5 Aug 10, 2021
SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
lexierule pushed a commit that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants