-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix distributed types support for CPUs #8667
Merged
kaushikb11
merged 7 commits into
Lightning-AI:master
from
kaushikb11:fix/training_type_cpu
Aug 2, 2021
Merged
Fix distributed types support for CPUs #8667
kaushikb11
merged 7 commits into
Lightning-AI:master
from
kaushikb11:fix/training_type_cpu
Aug 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8667 +/- ##
=======================================
- Coverage 93% 88% -4%
=======================================
Files 168 168
Lines 13984 13985 +1
=======================================
- Hits 12948 12355 -593
- Misses 1036 1630 +594 |
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 1, 2021 20:07
awaelchli
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaushikb11 there are failing tests, likely due to the change to the num_gpus -> has_gpu change
SeanNaren
approved these changes
Aug 2, 2021
kaushikb11
force-pushed
the
fix/training_type_cpu
branch
from
August 2, 2021 10:29
9b703f3
to
a5c0d61
Compare
carmocca
approved these changes
Aug 2, 2021
awaelchli
pushed a commit
that referenced
this pull request
Aug 3, 2021
awaelchli
pushed a commit
that referenced
this pull request
Aug 3, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes distributed types support for CPUs(DistributedType.DP, DistributedType.DDP2).
Change it to
ddp
, ifdp
orddp2
is passed forcpus
.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃