Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distributed types support for CPUs #8667

Merged
merged 7 commits into from
Aug 2, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Aug 1, 2021

What does this PR do?

Fixes distributed types support for CPUs(DistributedType.DP, DistributedType.DDP2).
Change it to ddp, if dp or ddp2 is passed for cpus.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #8667 (a5c0d61) into master (85bba06) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8667    +/-   ##
=======================================
- Coverage      93%     88%    -4%     
=======================================
  Files         168     168            
  Lines       13984   13985     +1     
=======================================
- Hits        12948   12355   -593     
- Misses       1036    1630   +594     

@kaushikb11 kaushikb11 added the bug Something isn't working label Aug 1, 2021
@kaushikb11 kaushikb11 added this to the v1.4.x milestone Aug 1, 2021
@kaushikb11 kaushikb11 added the priority: 0 High priority task label Aug 1, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review August 1, 2021 20:07
@kaushikb11 kaushikb11 marked this pull request as draft August 2, 2021 06:05
@kaushikb11 kaushikb11 marked this pull request as ready for review August 2, 2021 07:13
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikb11 there are failing tests, likely due to the change to the num_gpus -> has_gpu change

@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2021
@kaushikb11 kaushikb11 force-pushed the fix/training_type_cpu branch from 9b703f3 to a5c0d61 Compare August 2, 2021 10:29
@kaushikb11 kaushikb11 merged commit 850416f into Lightning-AI:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants