Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for unique device ids #8666

Merged

Conversation

nasnoisaac
Copy link
Contributor

@nasnoisaac nasnoisaac commented Aug 1, 2021

What does this PR do?

Fixes #8634

Check the uniqueness of gpu ids. The backend doesn't support duplicate GPU.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Aug 1, 2021

Hello @nasnoisaac! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-03 07:45:54 UTC

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #8666 (7d3a525) into master (e5d9e21) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8666    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         167     167            
  Lines       14033   14037     +4     
=======================================
- Hits        13004   12453   -551     
- Misses       1029    1584   +555     

@carmocca carmocca added the feature Is an improvement or enhancement label Aug 1, 2021
@carmocca carmocca added this to the v1.5 milestone Aug 1, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the CHANGELOG :)

@awaelchli awaelchli changed the title refactor: make gpu ids unique add check for unique device ids Aug 2, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2021
@carmocca carmocca enabled auto-merge (squash) August 2, 2021 10:33
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this check @nasnoisaac !

@mergify mergify bot added the has conflicts label Aug 2, 2021
@mergify mergify bot removed the has conflicts label Aug 3, 2021
@carmocca carmocca merged commit 8274183 into Lightning-AI:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error against specifying duplicate GPU device ids?
7 participants