WandbLogger to log model topology by default

[gau-nernst]

What does this PR do?

Fixes #8638

• Add log_graph=True parameter to WandbLogger.watch() and pass it to wandb.watch()
• Update wandb logger test to include log_graph

Recently wandb introduces the parameter log_graph in wandb.watch(). By default, it is False, so model topology won't be logged (see here)

Does your PR introduce any breaking changes? If yes, please list them.

• log_graph=True by default.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #8662 (1d7da67) into master (560a5c3) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8662   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         169     169           
  Lines       14075   14075           
======================================
  Hits        12468   12468           
  Misses       1607    1607           

[tchaton]

LGTM ! Any idea of implication on training performance ?

[gau-nernst]

I don't think it will have any negative impacts on training performance, because it's just extra logging. This was the default behavior for wandb some time ago (before wandb client commit #2395 on July 16)

I just found out that wandb added log_graph=False in their wandb.watch() in this and this commits. This means that earlier version of wandb client will throw an error because we have passed an extra argument (I haven't tested this).

Should we raise the minimum version requirement for wandb logger? Or we discard my PR and leave the user handle this behavior by themselves? (which is what I'm doing for my project)

[awaelchli]

This is great. Impact is minor since this needs to be called manually anyway.
@gau-nernst could you add a changelog entry in CHANGELOG.md ?

[awaelchli]

@gau-nernst if you merge master into this branch the failing gpu test will pass and we can merge.

[gau-nernst]

@awaelchli I have rebased from master and added an entry to CHANGELOG.md
The GPU test has passed now. Thank you for the support!