-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ddp
accelerator choice for cpu
#8645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
July 30, 2021 13:32
Codecov Report
@@ Coverage Diff @@
## master #8645 +/- ##
======================================
Coverage 88% 89%
======================================
Files 168 167 -1
Lines 13985 13966 -19
======================================
+ Hits 12355 12393 +38
+ Misses 1630 1573 -57 |
carmocca
approved these changes
Jul 30, 2021
justusschock
approved these changes
Jul 30, 2021
Borda
reviewed
Jul 30, 2021
SeanNaren
reviewed
Jul 30, 2021
SeanNaren
approved these changes
Jul 30, 2021
kaushikb11
force-pushed
the
fix/ddp_for_cpu
branch
2 times, most recently
from
August 2, 2021 10:18
2309792
to
89613db
Compare
kaushikb11
force-pushed
the
fix/ddp_for_cpu
branch
from
August 2, 2021 11:15
89613db
to
646bfcd
Compare
Hello @kaushikb11! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-02 16:54:15 UTC |
for more information, see https://pre-commit.ci
awaelchli
pushed a commit
that referenced
this pull request
Aug 3, 2021
awaelchli
pushed a commit
that referenced
this pull request
Aug 3, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
ddp
accelerator choice for cpuDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃