-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix references for ResultCollection.extra
and improve str
and repr
#8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8622 +/- ##
======================================
Coverage 93% 93%
======================================
Files 168 168
Lines 13951 13956 +5
======================================
+ Hits 12909 12914 +5
Misses 1042 1042 |
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
July 29, 2021 15:38
awaelchli
approved these changes
Jul 29, 2021
Borda
approved these changes
Jul 29, 2021
tchaton
approved these changes
Jul 30, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
…pr` (#8622) Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli
pushed a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
pushed a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
pushed a commit
that referenced
this pull request
Aug 3, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where the
ResultCollection.extra
return dict was not set back to the object in the default case.Also improve its string representations.
Found while debugging #8613
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review