-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reference issues during epoch end result collection #8621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8621 +/- ##
======================================
Coverage 93% 93%
======================================
Files 168 168
Lines 13951 13951
======================================
+ Hits 12909 12911 +2
+ Misses 1042 1040 -2 |
carmocca
changed the title
Fix references for
Fix reference issues during epoch end result collection
Jul 29, 2021
ResultCollection.extra
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
July 29, 2021 17:47
awaelchli
approved these changes
Jul 29, 2021
awaelchli
reviewed
Jul 29, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
tchaton
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
justusschock
approved these changes
Jul 30, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
awaelchli
added a commit
that referenced
this pull request
Aug 3, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Aug 3, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes 2 issues:
_process_training_step_output
method was modifying the training step output, which could be problematic if the user saved it intraining_batch_end
._prepare_outputs
function was modifying the currentResultCollection.extra
dictionary._track_epoch_end_reduce_metrics
method wasn't collapsing the sequence if only one element when it was aResultCollection
. This was probably a remnant from theResult
/dict
return days.The added test covers both
Found while debugging #8613
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃