Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix collecting training_step outputs #8613

Merged
merged 13 commits into from
Jul 30, 2021
Merged

fix collecting training_step outputs #8613

merged 13 commits into from
Jul 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 29, 2021

What does this PR do?

Fixes #8603

With git bisect found that #7891 had introduced the issue by removing a "copy" of the training step output here.

Tests fail on master, reproducing the issue.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

not this time 😢

@awaelchli awaelchli added priority: 0 High priority task bug Something isn't working labels Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8613 (80471e7) into master (5789e9f) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8613    +/-   ##
=======================================
+ Coverage      88%     93%    +4%     
=======================================
  Files         168     168            
  Lines       13968   13969     +1     
=======================================
+ Hits        12337   12932   +595     
+ Misses       1631    1037   -594     

@awaelchli awaelchli mentioned this pull request Jul 29, 2021
11 tasks
@awaelchli awaelchli marked this pull request as ready for review July 29, 2021 10:44
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@awaelchli awaelchli added this to the v1.4.x milestone Jul 29, 2021
@mergify mergify bot added the ready PRs ready to be merged label Jul 29, 2021
@awaelchli awaelchli force-pushed the bugfix/loop-end-outputs branch from 8844a52 to 6f3afb2 Compare July 29, 2021 20:53
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@awaelchli awaelchli marked this pull request as ready for review July 30, 2021 07:42
@tchaton tchaton enabled auto-merge (squash) July 30, 2021 10:00
@mergify mergify bot removed the has conflicts label Jul 30, 2021
@mergify mergify bot removed the has conflicts label Jul 30, 2021
@tchaton tchaton merged commit 529c42f into master Jul 30, 2021
@tchaton tchaton deleted the bugfix/loop-end-outputs branch July 30, 2021 13:03
awaelchli added a commit that referenced this pull request Jul 31, 2021
awaelchli added a commit that referenced this pull request Jul 31, 2021
awaelchli added a commit that referenced this pull request Jul 31, 2021
awaelchli added a commit that referenced this pull request Aug 3, 2021
lexierule pushed a commit that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputs in training_epoch_end contain only outputs from last batch repeated
6 participants