-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix collecting training_step outputs #8613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #8613 +/- ##
=======================================
+ Coverage 88% 93% +4%
=======================================
Files 168 168
Lines 13968 13969 +1
=======================================
+ Hits 12337 12932 +595
+ Misses 1631 1037 -594 |
11 tasks
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
July 29, 2021 10:44
ethanwharris
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
carmocca
approved these changes
Jul 29, 2021
ananthsub
approved these changes
Jul 29, 2021
This was referenced Jul 29, 2021
11 tasks
awaelchli
force-pushed
the
bugfix/loop-end-outputs
branch
from
July 29, 2021 20:53
8844a52
to
6f3afb2
Compare
justusschock
approved these changes
Jul 30, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
added a commit
that referenced
this pull request
Jul 31, 2021
awaelchli
added a commit
that referenced
this pull request
Aug 3, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8603
With git bisect found that #7891 had introduced the issue by removing a "copy" of the training step output here.
Tests fail on master, reproducing the issue.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
not this time 😢