Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune deprecated metrics #8586

Merged
merged 9 commits into from
Jul 28, 2021
Merged

Prune deprecated metrics #8586

merged 9 commits into from
Jul 28, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 27, 2021

What does this PR do?

remove deprecated metrics from the codebase

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added this to the v1.5 milestone Jul 27, 2021
@Borda Borda marked this pull request as draft July 27, 2021 16:25
@Borda Borda marked this pull request as ready for review July 27, 2021 16:42
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #8586 (fb1051b) into master (6b47cbe) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8586    +/-   ##
=======================================
  Coverage      92%     93%            
=======================================
  Files         218     169    -49     
  Lines       14398   13987   -411     
=======================================
- Hits        13296   12944   -352     
+ Misses       1102    1043    -59     

@mergify mergify bot added the ready PRs ready to be merged label Jul 27, 2021
@Borda Borda enabled auto-merge (squash) July 28, 2021 16:09
@Borda Borda merged commit 0c0b24c into master Jul 28, 2021
@Borda Borda deleted the prune/metrics branch July 28, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants