-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Support for DeepSpeed #8488
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8488 +/- ##
======================================
Coverage 92% 92%
======================================
Files 217 217
Lines 14328 14342 +14
======================================
+ Hits 13222 13236 +14
Misses 1106 1106 |
@SeanNaren How are you testing it on Windows? |
@kaushikb11 I've added a weak test to ensure that the function runs correctly when the platform is Windows, however actually testing this will be extremely difficult. I think we'll rely on user testing + deepspeed to ensure correct communication paths! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
Closes #6651.
To test this, I think I'll have to mock a bunch of things and ensure initialization works on Windows.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃