Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support for DeepSpeed #8488

Merged
merged 7 commits into from
Jul 20, 2021
Merged

Add Windows Support for DeepSpeed #8488

merged 7 commits into from
Jul 20, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jul 20, 2021

What does this PR do?

Closes #6651.

To test this, I think I'll have to mock a bunch of things and ensure initialization works on Windows.

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #8488 (9f91f9f) into master (0ac9e2a) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8488   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         217     217           
  Lines       14328   14342   +14     
======================================
+ Hits        13222   13236   +14     
  Misses       1106    1106           

@SeanNaren SeanNaren changed the title Modify deepspeed distributed to support windows Add Windows Support for DeepSpeed Jul 20, 2021
@kaushikb11
Copy link
Contributor

@SeanNaren How are you testing it on Windows?

@SeanNaren
Copy link
Contributor Author

@kaushikb11 I've added a weak test to ensure that the function runs correctly when the platform is Windows, however actually testing this will be extremely difficult. I think we'll rely on user testing + deepspeed to ensure correct communication paths!

@SeanNaren SeanNaren marked this pull request as ready for review July 20, 2021 11:51
@carmocca carmocca added this to the v1.4 milestone Jul 20, 2021
@carmocca carmocca added 3rd party Related to a 3rd-party distributed Generic distributed-related topic bug Something isn't working labels Jul 20, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jul 20, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) July 20, 2021 13:20
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@SeanNaren SeanNaren merged commit 8a9ee40 into master Jul 20, 2021
@SeanNaren SeanNaren deleted the fix/ds_windows branch July 20, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Deepspeed on Windows
6 participants