Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset Loops total counters #8475

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Conversation

carmocca
Copy link
Contributor

What does this PR do?

When progress is restored, we want to reset the current counters ready/started attributes to properly restart.
However, not for the total counters which should never get decremented and aren't used to restart.

Does your PR introduce any breaking changes ? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Jul 19, 2021
@carmocca carmocca added this to the v1.4 milestone Jul 19, 2021
@carmocca carmocca self-assigned this Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #8475 (24bc200) into master (7d93d70) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8475   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         217     217           
  Lines       14258   14256    -2     
======================================
- Hits        13230   13159   -71     
- Misses       1028    1097   +69     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jul 19, 2021
@carmocca carmocca enabled auto-merge (squash) July 19, 2021 13:32
@carmocca carmocca merged commit a6fd32a into master Jul 19, 2021
@carmocca carmocca deleted the bugfix/do-not-reset-total-counters branch July 19, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants