Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quant as optional step #8464

Merged
merged 22 commits into from
Jul 22, 2021
Merged

Quant as optional step #8464

merged 22 commits into from
Jul 22, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 19, 2021 •
edited
Loading

What does this PR do?

Fixes #7427

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working checkpointing Related to checkpointing callback priority: 1 Medium priority task labels Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021 •
edited
Loading

Codecov Report

Merging #8464 (da57f46) into master (0ac9e2a) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8464   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         217     218    +1     
  Lines       14328   14401   +73     
======================================
+ Hits        13222   13290   +68     
- Misses       1106    1111    +5

@pep8speaks
Copy link

pep8speaks commented Jul 19, 2021 •
edited
Loading

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-22 12:10:12 UTC

@Borda Borda marked this pull request as ready for review July 19, 2021 18:24
@Borda Borda changed the title fixing Quant reloading Quant as optional step Jul 20, 2021
@Borda Borda removed the checkpointing Related to checkpointing label Jul 20, 2021
@mergify mergify bot removed the has conflicts label Jul 20, 2021
awaelchli
awaelchli approved these changes Jul 20, 2021
View reviewed changes
pytorch_lightning/callbacks/quantization.py Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
@Borda @awaelchli @carmocca
Apply suggestions from code review
3acbbdc 
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda Borda requested a review from carmocca July 20, 2021 15:13
carmocca
carmocca reviewed Jul 20, 2021
View reviewed changes
tests/callbacks/test_quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from carmocca July 20, 2021 20:48
@Borda
Copy link
Member Author

Borda commented Jul 21, 2021

FYI, the failing tests came from master...

tchaton
tchaton approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jul 21, 2021
carmocca
carmocca reviewed Jul 21, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) July 22, 2021 10:35
@awaelchli awaelchli changed the title Quant as optional step add quantize_on_fit_end argument to QuantizationAwareTraining Jul 22, 2021
@awaelchli awaelchli changed the title add quantize_on_fit_end argument to QuantizationAwareTraining Quant as optional step Jul 22, 2021
@awaelchli awaelchli merged commit b7dbcc3 into master Jul 22, 2021
@awaelchli awaelchli deleted the fix/quant branch July 22, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working callback priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow calling fit multiple times with Quantization (QAT)
5 participants
@Borda @pep8speaks @awaelchli @carmocca @tchaton