Hash values in LightningEnum instead of name.

[ramonemiliani93]

What does this PR do?

Fixes enums hash by name and not by value. For example:

TrainerFn.FITTING in (None, "fit") # True
TrainerFn.FITTING in {None, "fit"} # False

Both should have the same result.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
• Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #8421 (20320a3) into master (adaa32f) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8421    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         217     217            
  Lines       14225   14225            
=======================================
- Hits        13199   12536   -663     
- Misses       1026    1689   +663     

[carmocca]

Can you add a test for this?

You can do so with a doctest for DeviceType in line 85

    >>> # which is case invariant
    >>> DeviceType.TPU in ('tpu', 'CPU')
    True
+   >>> DeviceType.TPU in {'tpu', 'CPU'}
+   True

[ramonemiliani93]

Done! Let me know if everything is fine 🙌

[carmocca]

Oh and one last thing, needs an entry in the "Fixed" section of https://github.com/PyTorchLightning/pytorch-lightning/blob/master/CHANGELOG.md

[tchaton]

Dear @ramonemiliani93,

Weird, enum doesn't play nice with Set. Might be worth to replace it with list and get this merge.

Best,
T.C