Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add FastForwardSampler 2/n - Fault Tolerant Training #8307

Merged
merged 38 commits into from
Jul 7, 2021
Merged

[Feat] Add FastForwardSampler 2/n - Fault Tolerant Training #8307

merged 38 commits into from
Jul 7, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 6, 2021 •
edited
Loading

What does this PR do?

This PR is part of the Fault Tolerant Training work.

Linked to PoC: #8131

This adds the FastForwardSampler, CaptureIterativeDataset and bunch of tests to insure right behaviour.

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 6, 2021 •
edited
Loading

Hello @tchaton! Thanks for updating this PR.

Line 390:13: W503 line break before binary operator

Comment last updated at 2021-07-07 19:31:12 UTC

@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #8307 (6daff95) into master (bca5adf) will decrease coverage by 4%.
The diff coverage is 91%.

@@           Coverage Diff           @@
##           master   #8307    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         213     214     +1     
  Lines       13798   13900   +102     
=======================================
- Hits        12744   12217   -527     
- Misses       1054    1683   +629

@tchaton tchaton marked this pull request as ready for review July 6, 2021 18:45
@tchaton tchaton mentioned this pull request Jul 7, 2021
Closed
11 tasks
@tchaton tchaton self-assigned this Jul 7, 2021
@tchaton tchaton added the design Includes a design discussion label Jul 7, 2021
@tchaton tchaton added this to the v1.4 milestone Jul 7, 2021
ethanwharris
ethanwharris approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments

pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) July 7, 2021 13:38
carmocca
carmocca reviewed Jul 7, 2021
View reviewed changes
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Show resolved Hide resolved
@carmocca carmocca disabled auto-merge July 7, 2021 15:20
awaelchli
awaelchli approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accept to unblock <3

@tchaton tchaton enabled auto-merge (squash) July 7, 2021 15:57
@carmocca carmocca disabled auto-merge July 7, 2021 16:02
@tchaton tchaton enabled auto-merge (squash) July 7, 2021 16:48
@tchaton tchaton merged commit 7956c6b into master Jul 7, 2021
@tchaton tchaton deleted the add_fast_forward_sampler branch July 7, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@ethanwharris ethanwharris ethanwharris approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@justusschock justusschock justusschock approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
design Includes a design discussion
Projects
None yet
Milestone
pl:1.4
Development

Successfully merging this pull request may close these issues.
8 participants
@tchaton @pep8speaks @awaelchli @SeanNaren @ethanwharris @carmocca @justusschock @kaushikb11