[feat] Add restore to base loop #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #8247 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 212 212
Lines 13695 13710 +15
=======================================
- Hits 12735 12068 -667
- Misses 960 1642 +682 |
ananthsub
reviewed
Jul 1, 2021
yifuwang
reviewed
Jul 1, 2021
On restart, loading the state dict isn't enough, you would need to do multiple things depending on your loop such as fast forwarding samplers, skip progress tracking reset, etc... Linked to this PR: #8131 Best, |
awaelchli
approved these changes
Jul 1, 2021
carmocca
reviewed
Jul 1, 2021
ethanwharris
approved these changes
Jul 2, 2021
carmocca
reviewed
Jul 2, 2021
Comment on lines
+49
to
+57
| self._restarting = False | ||
|
|
||
| @property | ||
| def restarting(self) -> bool: | ||
| return self._restarting | ||
|
|
||
| @restarting.setter | ||
| def restarting(self, restarting: bool) -> None: | ||
| self._restarting = restarting |
There was a problem hiding this comment.
Is there a reason why you added a getter/setter considering they don't do anything custom?
There was a problem hiding this comment.
Not a strong need for them right now. Can be removed later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds restore to base loop and is_restarting boolean.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃