Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecate] Deprecate LightningModule.loaded_optimizer_states_dict #8229

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Jul 1, 2021

What does this PR do?

This is a property on the core LightningModule API, but there are no references to it anywhere else in the project. As a result, I propose deprecating it to clean up the API

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added this to the v1.4 milestone Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #8229 (644a8ee) into master (d51b0ae) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8229    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         212     212            
  Lines       13695   13703     +8     
=======================================
- Hits        12735   12060   -675     
- Misses        960    1643   +683     

@carmocca carmocca enabled auto-merge (squash) July 1, 2021 10:06
@carmocca carmocca added the ready PRs ready to be merged label Jul 1, 2021
@mergify mergify bot added the has conflicts label Jul 1, 2021
@mergify mergify bot removed the has conflicts label Jul 1, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removing without any replacement?

@carmocca carmocca merged commit 8b0aec8 into Lightning-AI:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants