Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double precision casting complex buffers #8208

Merged
merged 7 commits into from
Jun 30, 2021

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Jun 29, 2021

What does this PR do?

Fixes #8178

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #8208 (dbc6ff9) into master (2e537b7) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8208   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         212     212           
  Lines       13595   13595           
======================================
- Hits        12579   12568   -11     
- Misses       1016    1027   +11     

Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carmocca carmocca added the bug Something isn't working label Jun 29, 2021
@carmocca carmocca added this to the v1.3.x milestone Jun 29, 2021
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 29, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 29, 2021 23:47
@awaelchli awaelchli disabled auto-merge June 30, 2021 00:22
@ethanwharris ethanwharris merged commit 57dce72 into master Jun 30, 2021
@ethanwharris ethanwharris deleted the bugfix/double_complex branch June 30, 2021 09:57
@ethanwharris ethanwharris removed this from the v1.3.x milestone Jul 6, 2021
@ethanwharris ethanwharris added this to the v1.4 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer sets incorrect precision for complex dtype
5 participants