Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple device parsing logic from Acc connector to Trainer #8180

Merged
merged 7 commits into from
Jul 7, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jun 28, 2021

What does this PR do?

Step towards simplifying the Accelerator Connector.

Before submitting

  • [] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [] Did you make sure to update the documentation with your changes? (if necessary)
  • [] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #8180 (cf427d1) into master (bf54ac1) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8180   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         212     212           
  Lines       13542   13547    +5     
======================================
- Hits        11958   11903   -55     
- Misses       1584    1644   +60     

@kaushikb11 kaushikb11 self-assigned this Jun 28, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review June 28, 2021 18:59
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment 😃

pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@Borda Borda added the design Includes a design discussion label Jun 28, 2021
@mergify mergify bot removed the has conflicts label Jun 28, 2021
@Borda Borda requested review from Borda, tchaton and justusschock July 6, 2021 08:37
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 6, 2021 15:36
@kaushikb11 kaushikb11 added this to the v1.4 milestone Jul 6, 2021
@kaushikb11 kaushikb11 merged commit 2b6edae into Lightning-AI:master Jul 7, 2021
@kaushikb11 kaushikb11 deleted the device_parsing branch November 1, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants