[bugfix] Resolve memory not logged when missing metrics #8174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/PyTorchLightning/pytorch-lightning into bugfix/8159_log_gpu_memory_on_step
tchaton
added
bug
Codecov Report
@@ Coverage Diff @@
## master #8174 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 211 211
Lines 13440 13450 +10
=======================================
- Hits 12474 11837 -637
- Misses 966 1613 +647 |
tchaton
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
justusschock
approved these changes
Jun 28, 2021
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Show resolved
Hide resolved
awaelchli
approved these changes
Jun 28, 2021
ananthsub
reviewed
Jun 28, 2021
| for key, mem in self.gpus_metrics.items(): | ||
| gpu_id = int(key.split('/')[0].split(':')[1]) | ||
| if gpu_id in self.trainer.accelerator_connector.parallel_device_ids: | ||
| self.trainer.lightning_module.log(key, mem, prog_bar=False, logger=True, on_step=True, on_epoch=False) |
There was a problem hiding this comment.
since we're already in the trainer, why do we have to log through the lightning module's log ?
carmocca
reviewed
Jun 29, 2021
Comment on lines
+283
to
+289
| @property | ||
| def gpus_metrics(self) -> Dict[str, str]: | ||
| if self.trainer._device_type == DeviceType.GPU and self.log_gpu_memory: | ||
| mem_map = memory.get_memory_profile(self.log_gpu_memory) | ||
| self._gpus_metrics.update(mem_map) | ||
| return self._gpus_metrics | ||
|
|
There was a problem hiding this comment.
Why did this PR need to add _gpu_metrics? Doesn't seem related to the issue linked.
This means that gpu metrics are now duplicated in this dictionary and in logged metrics.
Also it only gets filled when self.log_gpu_memory so it can't be used anyways without the flag.
There was a problem hiding this comment.
This was referenced Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds gpus_metrics to ResultCollection + filter the non requested gpus for logging
Fixes #8159
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃