Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resurface lost ddp info message #8111

Merged
merged 10 commits into from
Jun 27, 2021
Merged

resurface lost ddp info message #8111

merged 10 commits into from
Jun 27, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 24, 2021

What does this PR do?

The following message disappeared from Lightning:

----------------------------------------------------------------------------------------------------
distributed_backend=ddp
All DDP processes registered. Starting ddp with 2 processes
----------------------------------------------------------------------------------------------------

The condition for printing it was mistakenly if not torch.distributed.is_initialized, which would never be true since right before that we initialized the backend.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #8111 (7f52f71) into master (d4d5418) will decrease coverage by 0%.
The diff coverage is 75%.

@@          Coverage Diff           @@
##           master   #8111   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         209     211    +2     
  Lines       13412   13408    -4     
======================================
- Hits        12439   12409   -30     
- Misses        973     999   +26     

@awaelchli awaelchli added distributed Generic distributed-related topic bug Something isn't working labels Jun 24, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jun 24, 2021
@awaelchli awaelchli added the priority: 2 Low priority task label Jun 24, 2021
@awaelchli awaelchli marked this pull request as ready for review June 24, 2021 07:00
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@awaelchli awaelchli enabled auto-merge (squash) June 24, 2021 13:35
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 24, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 25, 2021

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-25 13:47:33 UTC

@awaelchli
Copy link
Contributor Author

@Borda the printing with tuple you suggested wasn't working because it would print everything on one line. I made use of f-strings now.

@Borda
Copy link
Member

Borda commented Jun 25, 2021

@Borda the printing with tuple you suggested wasn't working because it would print everything on one line. I made use of f-strings now.

so just add line end, for example os.linesep

@awaelchli awaelchli merged commit 51ea842 into master Jun 27, 2021
@awaelchli awaelchli deleted the bugfix/ddp-info-msg branch June 27, 2021 19:51
awaelchli added a commit that referenced this pull request Jun 29, 2021
awaelchli added a commit that referenced this pull request Jun 29, 2021
awaelchli added a commit that referenced this pull request Jun 30, 2021
awaelchli added a commit that referenced this pull request Jul 1, 2021
lexierule pushed a commit that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Generic distributed-related topic priority: 2 Low priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants