-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resurface lost ddp info message #8111
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #8111 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 209 211 +2
Lines 13412 13408 -4
======================================
- Hits 12439 12409 -30
- Misses 973 999 +26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix!
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-25 13:47:33 UTC |
for more information, see https://pre-commit.ci
@Borda the printing with tuple you suggested wasn't working because it would print everything on one line. I made use of f-strings now. |
so just add line end, for example |
What does this PR do?
The following message disappeared from Lightning:
The condition for printing it was mistakenly
if not torch.distributed.is_initialized
, which would never be true since right before that we initialized the backend.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃