Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke RPC #8101

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Nuke RPC #8101

merged 3 commits into from
Jun 23, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jun 23, 2021

What does this PR do?

Removes RPC integration

Everything was found with grep -irn "rpc" * --exclude .git

Arguments:

cc @justusschock @SeanNaren @tchaton @awaelchli @ananthsub

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor design Includes a design discussion labels Jun 23, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 23, 2021
@carmocca carmocca self-assigned this Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #8101 (93a3eb5) into master (8bd7b1b) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8101    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         211     209     -2     
  Lines       13658   13412   -246     
=======================================
- Hits        12512   11799   -713     
- Misses       1146    1613   +467     

@carmocca
Copy link
Contributor Author

carmocca commented Jun 23, 2021

Converting to draft to avoid merge until we know everybody is on the same page

@carmocca carmocca marked this pull request as draft June 23, 2021 14:59
@carmocca carmocca marked this pull request as ready for review June 23, 2021 18:16
@carmocca carmocca enabled auto-merge (squash) June 23, 2021 18:28
@carmocca carmocca merged commit 4d9b72b into master Jun 23, 2021
@carmocca carmocca deleted the refactor/nuke-rpc branch June 23, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants