-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Remove _run_evaluation + 3 EvaluationLoop #8065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8065 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 210 210
Lines 13593 13617 +24
======================================
- Hits 12466 12450 -16
- Misses 1127 1167 +40 |
carmocca
reviewed
Jun 21, 2021
pytorch_lightning/loops/dataloader/evaluation_dataloader_loop.py
Outdated
Show resolved
Hide resolved
awaelchli
reviewed
Jun 21, 2021
pytorch_lightning/loops/dataloader/evaluation_dataloader_loop.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/loops/dataloader/evaluation_dataloader_loop.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/loops/dataloader/evaluation_dataloader_loop.py
Outdated
Show resolved
Hide resolved
carmocca
reviewed
Jun 21, 2021
carmocca
reviewed
Jun 21, 2021
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
carmocca
reviewed
Jun 21, 2021
awaelchli
reviewed
Jun 21, 2021
awaelchli
approved these changes
Jun 22, 2021
pytorch_lightning/loops/dataloader/evaluation_dataloader_loop.py
Outdated
Show resolved
Hide resolved
11 tasks
Co-authored-by: Adrian Wälchli <[email protected]>
carmocca
reviewed
Jun 22, 2021
pytorch_lightning/loops/dataloader/evaluation_dataloader_loop.py
Outdated
Show resolved
Hide resolved
justusschock
approved these changes
Jun 22, 2021
carmocca
approved these changes
Jun 22, 2021
14 tasks
ananthsub
reviewed
Jun 24, 2021
""" | ||
if self.skip: | ||
return | ||
return self.on_skip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, why does the caller call run
if skip is publicly exposed?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates 2 validation Loop. One in FitLoop and one on the trainer.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃