Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove _run_evaluation + 3 EvaluationLoop #8065

Merged
merged 19 commits into from
Jun 22, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 21, 2021

What does this PR do?

This PR creates 2 validation Loop. One in FitLoop and one on the trainer.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Jun 21, 2021
@tchaton tchaton added this to the v1.4 milestone Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #8065 (7c617a5) into master (5d44e61) will decrease coverage by 0%.
The diff coverage is 93%.

@@          Coverage Diff           @@
##           master   #8065   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13593   13617   +24     
======================================
- Hits        12466   12450   -16     
- Misses       1127    1167   +40     

@tchaton tchaton marked this pull request as ready for review June 21, 2021 16:35
@carmocca carmocca added the feature Is an improvement or enhancement label Jun 21, 2021
@mergify mergify bot removed the has conflicts label Jun 22, 2021
@carmocca carmocca merged commit f79f0f9 into master Jun 22, 2021
@carmocca carmocca deleted the add_new_loops branch June 22, 2021 14:10
"""
if self.skip:
return
return self.on_skip()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, why does the caller call run if skip is publicly exposed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants